Fix channel order bug and make select_channels private - #4712
Open
chrishalcrow wants to merge 11 commits into
Open
Fix channel order bug and make select_channels private#4712chrishalcrow wants to merge 11 commits into
select_channels private#4712chrishalcrow wants to merge 11 commits into
Conversation
alejoe91
requested changes
Jul 24, 2026
chrishalcrow
marked this pull request as ready for review
July 24, 2026 12:20
alejoe91
reviewed
Jul 24, 2026
alejoe91
reviewed
Jul 24, 2026
alejoe91
requested changes
Jul 24, 2026
alejoe91
left a comment
alejoe91
left a comment
Member
There was a problem hiding this comment.
Another couple of minor comments :)
alejoe91
approved these changes
Jul 27, 2026
alejoe91
reviewed
Jul 29, 2026
Comment on lines
+268
to
+274
| channel_indices = [] | ||
| unit_channel_ids = old_unit_id_to_channel_ids[unit_id] | ||
|
|
||
| for channel_id in channel_ids: | ||
| if channel_id in unit_channel_ids: | ||
| idx = np.where(old_unit_id_to_channel_ids[unit_id] == channel_id)[0][0] | ||
| channel_indices.append(idx) |
Member
There was a problem hiding this comment.
Suggested change
| channel_indices = [] | |
| unit_channel_ids = old_unit_id_to_channel_ids[unit_id] | |
| for channel_id in channel_ids: | |
| if channel_id in unit_channel_ids: | |
| idx = np.where(old_unit_id_to_channel_ids[unit_id] == channel_id)[0][0] | |
| channel_indices.append(idx) | |
| unit_channel_ids = old_unit_id_to_channel_ids[unit_id] | |
| channel_ids_in_unit = [ch for ch in channel_ids if channel_id in unit_channel_ids] | |
| channel_indices = self.sorting_analyzer.channel_ids_to_indices(channel_ids_in_unit) |
I think that this does the exact same thing, right?
Member
Author
There was a problem hiding this comment.
You need the old channel_ids_to_indices, not the new ones from self.sorting_analyzer.channel_ids_to_indices
Member
There was a problem hiding this comment.
self is the old analyzer, no?
See:
old_waveforms = self.data["waveforms"]
Member
Author
There was a problem hiding this comment.
Oop - we're both wrong. The channel_indices tell you how to map between the channel_indices with respect to the sparsity mask for each unit (no the overall channel_indices). You can make the code look very simple if you have access to the new sorting_analyzer's sparsity mask, which we don't easily have.
I've updated the variables names, which I think should help avoid confusion.
alejoe91
reviewed
Jul 29, 2026
Comment on lines
+109
to
+115
| channel_indices = [] | ||
| unit_channel_ids = old_unit_id_to_channel_ids[unit_id] | ||
|
|
||
| for channel_id in channel_ids: | ||
| if channel_id in unit_channel_ids: | ||
| idx = np.where(old_unit_id_to_channel_ids[unit_id] == channel_id)[0][0] | ||
| channel_indices.append(idx) |
Member
There was a problem hiding this comment.
Suggested change
| channel_indices = [] | |
| unit_channel_ids = old_unit_id_to_channel_ids[unit_id] | |
| for channel_id in channel_ids: | |
| if channel_id in unit_channel_ids: | |
| idx = np.where(old_unit_id_to_channel_ids[unit_id] == channel_id)[0][0] | |
| channel_indices.append(idx) | |
| unit_channel_ids = old_unit_id_to_channel_ids[unit_id] | |
| channel_ids_in_unit = [ch for ch in channel_ids if channel_id in unit_channel_ids] | |
| channel_indices = self.sorting_analyzer.channel_ids_to_indices(channel_ids_in_unit) |
same here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a channel order bug in the sparsity mask for the new
select_channelsmethod for analyzers.Discussed with @alejoe91 and decided to keep this method private for now - we hope users will access through the
split_bymethod rather than directly.Fixed waveforms and pca selection.
Todo: add tests for waveforms and pca.